-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): add support for angular v19 #28847
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 782600e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
5538562
to
8e40c1a
Compare
e296983
to
4a76f00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so nice to see the ng-packagr adjustments removed
445e3a2
to
f24f778
Compare
906a779
to
5985cc2
Compare
7ba185e
to
2a9f15b
Compare
I wouldn't have expected that many changes. Nice to see that this is already prepared. Thanks for the great work 💪🏼 |
7f1d29a
to
5ebd437
Compare
when is that planned to be released? |
Curious what the nx protocol is with new versions of insert framework here. With angular, there are a bunch of release candidates and beta builds available prior to the GA release. I would assume nx would have no problem pushing out support for version x within a day or two of the GA release. But, angular was released on November 19th and nx hasn't pushed anything angular 19 related out yet. Is there a doc for "response time" with new releases? I fully understand each release differs in complexity given what features/changes are shipped with it. just seems between the the release candidates and beta builds there would be ample time to get something going that releases within a day or two of when the framework gets released. |
They just merged and deleted the feature branch not more than 4 hours ago. I'm sure its coming soon. |
I'm not pushing anyone for anything, it's a benign question :) |
I think that the answer is in the pull request description. We are waiting for corresponding releases of NgRx and Analog right now |
Can I stay on Angular 18.x with Nx 20.2.X? |
Yes this should be possible as of Interactively opting out of package updates |
The latest version of Nx supports the actively supported versions of Angular (current and LTS versions). From: https://nx.dev/nx-api/angular/documents/angular-nx-version-matrix This docs page has already been updated on See: https://canary.nx.dev/nx-api/angular/documents/angular-nx-version-matrix |
Yea, but that's this PR. I'd like to understand what the overall process is. Having NgRx hold up a release is odd... not everyone uses NgRx with Angular so it's wierd to hold a core component (angular) up because of an unrelated dependency (NgRx). Obviously, if you have NgRx in your angular app, you're not going to get too far in the upgrade path since NgRx and Angular have compatibility requirements. I'm about a year into using Nx and like it for the most part. However, I am not a fan of an unrelated thing blocking an upgrade path of a regular app. If we migrate to a new angular version and some crazy bug was found, not only do we have to wait on Angular to push out a fix, we have to wait on Nx to push out a fix, for a fix. Understanding how they prioritize versions and decide how quick they work on it would be great information. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Third-party deps support for Angular v19
jest-preset-angular
Current Behavior
Angular v19 is not supported.
Expected Behavior
Angular v19 should be supported.
Related Issue(s)
Fixes #29028