Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add support for angular v19 #28847

Merged
merged 36 commits into from
Dec 2, 2024
Merged

feat(angular): add support for angular v19 #28847

merged 36 commits into from
Dec 2, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Nov 8, 2024

@leosvelperez leosvelperez self-assigned this Nov 8, 2024
Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 11:17am

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so nice to see the ng-packagr adjustments removed

@DaSchTour
Copy link
Contributor

I wouldn't have expected that many changes. Nice to see that this is already prepared. Thanks for the great work 💪🏼

@FrozenPandaz FrozenPandaz merged commit 3ec5390 into master Dec 2, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the angular/v19 branch December 2, 2024 16:43
@robertIsaac
Copy link
Contributor

when is that planned to be released?

@marc-wilson
Copy link

marc-wilson commented Dec 2, 2024

Curious what the nx protocol is with new versions of insert framework here. With angular, there are a bunch of release candidates and beta builds available prior to the GA release. I would assume nx would have no problem pushing out support for version x within a day or two of the GA release. But, angular was released on November 19th and nx hasn't pushed anything angular 19 related out yet.

Is there a doc for "response time" with new releases? I fully understand each release differs in complexity given what features/changes are shipped with it. just seems between the the release candidates and beta builds there would be ample time to get something going that releases within a day or two of when the framework gets released.

@PieterjanDeClippel
Copy link

image

@dguisinger
Copy link

They just merged and deleted the feature branch not more than 4 hours ago. I'm sure its coming soon.

@robertIsaac
Copy link
Contributor

I'm not pushing anyone for anything, it's a benign question :)

@woppa684
Copy link

woppa684 commented Dec 3, 2024

After migrating to 20.2.0-beta.5:

image

@Marat-Gumerov
Copy link

Curious what the nx protocol is with new versions of insert framework here. With angular, there are a bunch of release candidates and beta builds available prior to the GA release. I would assume nx would have no problem pushing out support for version x within a day or two of the GA release. But, angular was released on November 19th and nx hasn't pushed anything angular 19 related out yet.

Is there a doc for "response time" with new releases? I fully understand each release differs in complexity given what features/changes are shipped with it. just seems between the the release candidates and beta builds there would be ample time to get something going that releases within a day or two of when the framework gets released.

I think that the answer is in the pull request description. We are waiting for corresponding releases of NgRx and Analog right now

@lppedd
Copy link

lppedd commented Dec 3, 2024

Can I stay on Angular 18.x with Nx 20.2.X?
I'd like to update Nx, but not Angular ATM.

@bohoffi
Copy link

bohoffi commented Dec 3, 2024

Can I stay on Angular 18.x with Nx 20.2.X? I'd like to update Nx, but not Angular ATM.

Yes this should be possible as of Interactively opting out of package updates

@isaacplmann
Copy link
Collaborator

The latest version of Nx supports the actively supported versions of Angular (current and LTS versions).

From: https://nx.dev/nx-api/angular/documents/angular-nx-version-matrix

This docs page has already been updated on master to show that the latest version of Nx supports back to Angular 17.0.0.

See: https://canary.nx.dev/nx-api/angular/documents/angular-nx-version-matrix

@marc-wilson
Copy link

marc-wilson commented Dec 3, 2024

I think that the answer is in the pull request description. We are waiting for corresponding releases of NgRx and Analog right now

Yea, but that's this PR. I'd like to understand what the overall process is. Having NgRx hold up a release is odd... not everyone uses NgRx with Angular so it's wierd to hold a core component (angular) up because of an unrelated dependency (NgRx). Obviously, if you have NgRx in your angular app, you're not going to get too far in the upgrade path since NgRx and Angular have compatibility requirements.

I'm about a year into using Nx and like it for the most part. However, I am not a fan of an unrelated thing blocking an upgrade path of a regular app. If we migrate to a new angular version and some crazy bug was found, not only do we have to wait on Angular to push out a fix, we have to wait on Nx to push out a fix, for a fix. Understanding how they prioritize versions and decide how quick they work on it would be great information.

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Angular 19 LTS